update package name and upgrade gin #10
Conversation
| "net/http" | ||
| "strconv" | ||
|
|
||
| "github.com/gin-gonic/gin" |
There was a problem hiding this comment.
Why we need use the dev version? Version related issue I think govendor is better and enough, https://github.com/gothinkster/golang-gin-realworld-example-app/blob/master/vendor/vendor.json
There was a problem hiding this comment.
Now gin no longer gopkg style, use govendor fetch github.com/gin-gonic/[email protected] can get v1.3.x branch not develop version.
There was a problem hiding this comment.
Got, I have half year not write go...
| @@ -6,11 +6,10 @@ import ( | |||
| "math/rand" | |||
| "time" | |||
|
|
|||
| "github.com/dgrijalva/jwt-go" | |||
There was a problem hiding this comment.
Sure? Might cause error can'f find jwt? I think we should delete all package in the vendor or GOPATH, and make sure all packages can be installed in a new environment.
There was a problem hiding this comment.
In fact, travis CI should do the work... but the gothinkster's repo didn't get right config... Let's wait Eric reply..
| "net/http" | ||
| "strings" | ||
|
|
||
| jwt "github.com/dgrijalva/jwt-go" |
There was a problem hiding this comment.
Same here. Codes LGTM, but please make sure it works fine in new environment.
|
Thank you very much! It's a very nice PR, I have left some comments. BTW, I don't know weather travis CI works fine, you could have a try on your own project firstly, that will reduce environment and version changing risk. |
|
@wangzitian0 thanks review, I will retry the weekend. |
|
why this is not merged ? |
|
why not merged? |
|
@wangzitian0 who got the write access to this repo? please notify him/her to merge this PR, thanks. |
No description provided.