Skip to content

feat: add custom classname inline style drawer component #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rianmandala wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add custom classname inline style drawer component #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895cd1f
chore: add support custom classname and inline style drawer component
rianputra01-png Sep 15, 2025
704c862
chore: bump version
rianputra01-png Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"packages": ["packages/*"],
"npmClient": "yarn",
"useWorkspaces": true,
"version": "0.11.9",
"version": "0.12.0-alpha.11",
"command": {
"version": {
"message": "chore(release): publish %s"
Expand Down
2 changes: 1 addition & 1 deletion packages/apsara-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@goto-company/icons",
"version": "0.11.9",
"version": "0.12.0-alpha.11",
"description": "Apsara icons",
"scripts": {
"build": "node scripts/build.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/apsara-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@goto-company/apsara",
"version": "0.11.9",
"version": "0.12.0-alpha.11",
"description": "A list of base components for apsara",
"author": "Praveen Yadav <[email protected]>",
"license": "Apache-2.0",
Expand Down
21 changes: 11 additions & 10 deletions packages/apsara-ui/src/Drawer/Drawer.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
import { useState } from 'react';
import Drawer from './Drawer';
import { useState } from "react";
import Drawer from "./Drawer";

export const Basic = () => {
const [open, setOpen] = useState(false);
return (
<>
<button type="button" onClick={() => setOpen(true)}>Click to open Drawer</button>
<Drawer
open={open}
onClose={() => setOpen(false)}
>
<button type="button" onClick={() => setOpen(true)}>
Click to open Drawer
</button>
<Drawer drawerStyle={{ zIndex: 1 }} open={open} onClose={() => setOpen(false)}>
<p>This is sample drawer content</p>
<button type="button" onClick={() => console.log('test')}>Test</button>
<button type="button" onClick={() => console.log("test")}>
Test
</button>
</Drawer>
</>
);
}
};

export default {
title: "Overlay/Drawer",
component: Drawer,
};
};
28 changes: 20 additions & 8 deletions packages/apsara-ui/src/Drawer/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,37 @@ type DrawerProps = {
className?: string;
position?: "left" | "right";
children?: React.ReactNode;
ContainerStyle?: React.CSSProperties;
ContainerClassName?: string;
};

const Drawer = ({ onOverlayClick, disableCloseOnOverlayClick, onClose, open = false, children, className = "", position = "right" }: DrawerProps) => {
const Drawer = ({
onOverlayClick,
disableCloseOnOverlayClick,
onClose,
open = false,
children,
className = "",
position = "right",
ContainerStyle = {},
ContainerClassName = "",
}: DrawerProps) => {
const theme = useContext(ThemeContext);

if (!open) return null;
return (
<Wrapper>
<Overlay onClick={() => {
if (!disableCloseOnOverlayClick) onClose();
if (onOverlayClick) onOverlayClick();
}}>
</Overlay>
<Wrapper className={ContainerClassName} style={ContainerStyle}>
<Overlay
onClick={() => {
if (!disableCloseOnOverlayClick) onClose();
if (onOverlayClick) onOverlayClick();
}}
></Overlay>
<Body className={className} position={position}>
<Icon name="cross" onClick={onClose} color={theme?.drawer?.close} />
{children}
</Body>
</Wrapper>

);
};

Expand Down