Skip to content

bug-fix: null check consumerRecord.value() before sending it to PB DynamicMessage.parseFrom #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajuGT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug-fix: null check consumerRecord.value() before sending it to PB DynamicMessage.parseFrom #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ain/java/com/gotocompany/dagger/common/serde/proto/deserialization/ProtoDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,13 @@ public boolean isEndOfStream(Row nextElement) {
@Override
public Row deserialize(ConsumerRecord<byte[], byte[]> consumerRecord) {
Descriptors.Descriptor descriptor = getProtoParser();
byte[] value = consumerRecord.value();
if (value == null) {
LOGGER.warn("Record value / byteArray is NULL! " + protoClassName);
return createDefaultInvalidRow(DynamicMessage.getDefaultInstance(descriptor));
Copy link
Member

@mayankrai09 mayankrai09 Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add metrics for this?

}
try {
DynamicMessage proto = DynamicMessage.parseFrom(descriptor, consumerRecord.value());
DynamicMessage proto = DynamicMessage.parseFrom(descriptor, value);
return addTimestampFieldToRow(proto);
} catch (DescriptorNotFoundException e) {
throw new DescriptorNotFoundException(e);
Expand Down
4 changes: 2 additions & 2 deletions dagger-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ dependencies {
exclude group: "io.grpc"
}
dependenciesJar 'org.apache.flink:flink-connector-kafka_2.11:' + flinkVersion
dependenciesJar 'com.google.protobuf:protobuf-java:3.23.2'
dependenciesJar 'com.google.protobuf:protobuf-java-util:3.1.0'
dependenciesJar 'com.google.protobuf:protobuf-java:3.25.3'
dependenciesJar 'com.google.protobuf:protobuf-java-util:3.25.3'
dependenciesJar 'org.influxdb:influxdb-java:2.8'
dependenciesJar 'org.elasticsearch.client:elasticsearch-rest-client:6.6.1'
dependenciesJar 'com.google.cloud.bigtable:bigtable-hbase-2.x:2.10.0'
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.12.1
0.12.2
Loading