Skip to content

fix: masking policy logging #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmadnaufal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: masking policy logging #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/store/maxcompute/masking_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func (h MaskingPolicyHandle) applyMaskPolicyChanges(trackersPerColumn []maskingP
).Inc()

err = parseMaskingPolicyError(err)
h.logger.Error("[masking-policy: error] action %s for masking policy %s to table %s.%s column %s failed: %s", task.Action, task.MaskingPolicy, task.ColumnName, schemaName, tableName, err.Error())
h.logger.Error("[masking-policy: error] action %s for masking policy %s to table %s.%s column %s failed: %s", task.Action, task.MaskingPolicy, schemaName, tableName, task.ColumnName, err.Error())
me.Append(fmt.Errorf("failed to %s masking policy %s for column %s: %s", task.Action, task.MaskingPolicy, task.ColumnName, err.Error()))
continue
}
Expand All @@ -172,7 +172,7 @@ func (h MaskingPolicyHandle) applyMaskPolicyChanges(trackersPerColumn []maskingP
).Inc()

err = parseMaskingPolicyError(err)
h.logger.Error("[masking-policy: error] action %s for masking policy %s to table %s.%s column %s failed: %s", task.Action, task.MaskingPolicy, task.ColumnName, schemaName, tableName, err.Error())
h.logger.Error("[masking-policy: error] action %s for masking policy %s to table %s.%s column %s failed: %s", task.Action, task.MaskingPolicy, schemaName, tableName, task.ColumnName, err.Error())
me.Append(fmt.Errorf("failed to %s masking policy %s to column %s: %s", task.Action, task.MaskingPolicy, task.ColumnName, err.Error()))
continue
}
Expand All @@ -185,7 +185,7 @@ func (h MaskingPolicyHandle) applyMaskPolicyChanges(trackersPerColumn []maskingP
maskingPolicyActionStatusSuccess,
).Inc()

h.logger.Info("[masking-policy: success] action %s for masking policy %s to table %s.%s column %s succeeded", task.Action, task.MaskingPolicy, task.ColumnName, schemaName, tableName)
h.logger.Info("[masking-policy: success] action %s for masking policy %s to table %s.%s column %s succeeded", task.Action, task.MaskingPolicy, schemaName, tableName, task.ColumnName)
}

return me.ToErr()
Expand Down
Loading