Skip to content

fix: detecting breach with state #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deryrahman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: detecting breach with state #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/scheduler/service/job_sla_predictor_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,8 @@ func (s *JobSLAPredictorService) identifySLABreachRootCauses(jobTarget *schedule
} else {
var state *JobState
// condition 1: T(now)>= S(u|j) and the job u has not completed yet
if (referenceTime.After(inferredSLA) && jobRun != nil && jobRun.JobEndTime == nil) || (jobRun != nil && jobRun.JobEndTime != nil && jobRun.JobEndTime.After(inferredSLA)) {
if (referenceTime.After(inferredSLA) && ((jobRun != nil && jobRun.JobEndTime == nil) || jobRun.JobStatus != scheduler.StateSuccess.String())) ||
(jobRun != nil && jobRun.JobEndTime != nil && jobRun.JobEndTime.After(inferredSLA)) {
// add to jobStatePaths
state = &JobState{
JobSLAState: *jobSLAStates[job.JobName],
Expand Down
8 changes: 8 additions & 0 deletions core/scheduler/service/job_sla_predictor_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ func TestIdentifySLABreaches(t *testing.T) {
JobRuns: map[scheduler.JobName]*scheduler.JobRunSummary{
jobALineage.JobName: {
ScheduledAt: scheduledAt.Add(-25 * time.Minute),
JobStatus: scheduler.StateSuccess.String(),
TaskStartTime: &jobCTaskStartTime,
TaskEndTime: &jobCTaskEndTime,
JobEndTime: &jobCTaskEndTime,
Expand Down Expand Up @@ -1023,6 +1024,7 @@ func TestIdentifySLABreaches(t *testing.T) {
JobRuns: map[scheduler.JobName]*scheduler.JobRunSummary{
jobALineage.JobName: {
ScheduledAt: scheduledAt.Add(-15 * time.Minute),
JobStatus: scheduler.StateSuccess.String(),
TaskStartTime: &jobBTaskStartTime,
TaskEndTime: &jobBTaskEndTime,
JobEndTime: &jobBTaskEndTime,
Expand All @@ -1039,6 +1041,7 @@ func TestIdentifySLABreaches(t *testing.T) {
JobRuns: map[scheduler.JobName]*scheduler.JobRunSummary{
jobALineage.JobName: {
ScheduledAt: scheduledAt.Add(-25 * time.Minute),
JobStatus: scheduler.StateSuccess.String(),
TaskStartTime: &jobCTaskStartTime,
TaskEndTime: &jobCTaskEndTime,
JobEndTime: &jobCTaskEndTime,
Expand Down Expand Up @@ -1170,10 +1173,12 @@ func TestIdentifySLABreach(t *testing.T) {
jobTargetLineageMap[jobName].JobRuns["job-1"].TaskStartTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].TaskEndTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].JobEndTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].JobStatus = ""
}
// job-18 is running late
jobTargetLineageMap["job-18"].JobRuns["job-1"].TaskEndTime = nil
jobTargetLineageMap["job-18"].JobRuns["job-1"].JobEndTime = nil
jobTargetLineageMap["job-18"].JobRuns["job-1"].JobStatus = ""

skipJobNames := map[scheduler.JobName]bool{}

Expand Down Expand Up @@ -1208,10 +1213,12 @@ func TestIdentifySLABreach(t *testing.T) {
jobTargetLineageMap[jobName].JobRuns["job-1"].TaskStartTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].TaskEndTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].JobEndTime = nil
jobTargetLineageMap[jobName].JobRuns["job-1"].JobStatus = ""
}
// job-18 is running late
jobTargetLineageMap["job-18"].JobRuns["job-1"].TaskEndTime = nil
jobTargetLineageMap["job-18"].JobRuns["job-1"].JobEndTime = nil
jobTargetLineageMap["job-18"].JobRuns["job-1"].JobStatus = ""

skipJobNames := map[scheduler.JobName]bool{}

Expand Down Expand Up @@ -1270,6 +1277,7 @@ func generateLineageWithSLAStates(slaPredictorService *service.JobSLAPredictorSe
jobRunSummary.TaskStartTime = &taskStartTime
jobRunSummary.TaskEndTime = &taskEndTime
jobRunSummary.JobEndTime = &taskEndTime
jobRunSummary.JobStatus = scheduler.StateSuccess.String()
}

return jobTargetLineageMap
Expand Down
Loading