fix(docker-compsose): add host.docker.internal as extra hosts #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host.docker.internal only works fine for inter-container communication for MacOS systems, at least according to the documentation we have. With this approach, Docker will handle all the OS-specific behaviour for us. This is a workaround that should eventually be removed Signed-off-by: GitHub <[email protected]>
ferferga
commented
Jun 5, 2024
There was a problem hiding this comment.
I left this one intact since the deployment we've been working on for the past month it's based on the docker-compose-local file, hence this one is untested and only the safest change (the extra_hosts addition) has been performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host.docker.internal only works fine for inter-container communication for MacOS systems, at least according to the documentation we have.
With this approach, Docker will handle all the OS-specific behaviour for us.
This is a workaround that should eventually be removed