Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test private api #58

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Unit test private api #58

merged 9 commits into from
Nov 20, 2023

Conversation

RobertByrnes
Copy link
Collaborator

@RobertByrnes RobertByrnes commented Oct 6, 2023

Introduce test suite for private api - @govorox wondering if you could take a look at this before I merge as it is a larger change. But really the only changes are:

  1. Adding doc blocks.
  2. Splitting start_ssl_client into smaller chunks to add visibility when things don't go as planned.
  3. Add unit tests for everything in ssl_client.cpp

@RobertByrnes RobertByrnes merged commit eee8718 into master Nov 20, 2023
@RobertByrnes RobertByrnes deleted the unit_test_private_api branch November 20, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant