Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the name of pers variable #70

Conversation

reusables-official
Copy link

for creating nonce, due to naming collision with WifiClientSecure

see discussion in issue 60

@reusables-official
Copy link
Author

reusables-official commented Apr 10, 2024

@RobertByrnes here is our includes list, it's a bit long but in the spirit of being comprehensive:

#include <ThingerESP32.h>
#include <ThingerESP32OTA.h>
#include <Arduino.h>
#include <ArduinoJson.h>
#include <ArduinoHttpClient.h>
#include <SPIFFS.h>
#include "SSLClient.h"

#include "string.h"
#include "config.h"
#include "secrets.h"
#include "network/certs.h"

ThingerESP32 thing(USERNAME, DEVICE_ID, DEVICE_CREDENTIAL);
ThingerESP32OTA ota(thing);

#include <LED.h>
#include "state.h"
#include <Cache.h>

#ifdef NETWORK_MODE_LTE
  #include "network/lte.h"
#endif

#ifdef NETWORK_MODE_WIFI
  #include "network/wpa.h"
#endif
#ifdef NETWORK_MODE_WPA2
  #include "network/wpa2.h"
#endif

#include "api.h"
#include "door.h"
#include <EPC.h>

#if defined(READER_MODE_RFID)
  #include <RFID.h>
#endif
#if defined(READER_MODE_QR)
  #include <QR.h>
#endif

fyi the original issue arose after I installed ThingerESP32.h, which internally uses WiFiClientSecure

Here is our platform.ini file, excuse my C++, it's rather entry level 🙄

[env:esp32-s3-devkitc-1]
platform = espressif32
board = esp32-s3-devkitc-1
framework = arduino
lib_deps = 
	thinger.io
	bblanchon/[email protected]
	vshymanskyy/[email protected]
	makuna/[email protected]
	arduino-libraries/[email protected]
	digitaldragon/[email protected]

@RobertByrnes RobertByrnes merged commit b8a9e7e into govorox:master Apr 11, 2024
1 check passed
@RobertByrnes
Copy link
Collaborator

RobertByrnes commented Apr 11, 2024

@reusables-official Thank you for your contribution! Just published 1.1.10 with the percy fix ....

@reusables-official reusables-official deleted the fix-pers-naming-collision-WiFiClientSecure branch April 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants