BAU: Fix flaky test in PersistentIdHelperTest #7236
Merged
+30
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IdGenerator.generate() can generate an ID with double dashes in it (`--`). This causes the assertion on the entropy check to fail, as the whole ID wasn't being passed into Base64.getUrlDecoder().decode(). - I've static mocked the IdGenerator here and made it return an example ID I generated previously. - I've updated auth's test for this too as it would impact both of our builds :)
|
Ryan-Andrews99
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wider context of change
IdGenerator.generate()can generate an ID with double dashes in it (--). This caused theBase64.getUrlDecoder().decode()call to throw anIllegalArgumentException, as only part of the ID was included as a parameter.What’s changed
I've static mocked the
IdGeneratorhere and made it return an example ID I generated previously. I've updated auth's test for this too as it would impact both of our builds :)Checklist