Solves "Synchronization on a non-final field 'audioLock'" #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as reported by IntelliJ: Analyze --> Inspect Code... This shouldn't change any actual behavior, since there are no write operations on audioLock. So effectivly, it was already final and non-volatile. This change explicitly forbids write operations on audioLock. Tested, of course.
|
This needs to be tested with XR3Player which can pause, resume, play and skip all from different Threads. I am merging for now, this change has a big importance. Probably we change all together synchronized blocks with something more recent like Atomic locks or something. I have saw some guys implementing their own version of StreamPlayer which had very big performance boost. I can't find their library on bit bucket. It was a Java media player on SourceForge and they had their code published on Bitbucket. They have an amazing implementation of StreamPlayer and new Spectrum Analyzer API. I have to find it... Like literally I was impressed but I didn't had the knowledge back then. |
|
Please check => #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported by IntelliJ: Analyze --> Inspect Code...
This shouldn't change any actual behavior, since there are no write operations on audioLock. So effectivly, it was already final and non-volatile. This change explicitly forbids write operations on audioLock.
Tested, of course.