This repository has been archived by the owner on Sep 21, 2020. It is now read-only.
GPII-3940: Exekube upgrade #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I'm not sure why you went to 0.6.0. I would have used 0.5.2 since none of these changes have compatibility consequences (and there are no other significant changes). |
|
Thanks for reviews.
I've chosen to bump minor in the spirit of semantic versioning - lots of the tools and providers upgraded bump their minor or even major versions, introduce new features and even some potentially backward incompatible changes. So while for us it might not mean any significant changes, I think in the context of exekube it wouldn't be enough to increase just patch version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades exekube image to
gpii/exekube:0.6.0-google_gpii.0. This upgrades Terraform, Terraform providers and other components, see gpii-ops/exekube#56 for details.This mainly fixes node_pool recreation due to metadata config (GPII-3940) - see GoogleCloudPlatform/magic-modules#1507 for details.
Also included is a small formatting fix for preferences chart which was causing wrong yaml indentation and deployment spec validation fail with new helm.