WIP: Tests and Benchmarks #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngc92
force-pushed
the
ngc92/test-and-benchmark
branch
from
8faa2f9 to
f11ec7e
Compare
ngc92
force-pushed
the
ngc92/test-and-benchmark
branch
from
988211d to
68bb0df
Compare
…hmark' into ngc92/test-and-benchmark
…hmark' into ngc92/test-and-benchmark
…d-cluster-manager into ngc92/test-and-benchmark
alexzhang13
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Tested locally, all bugs @S1ro1 and I found were fixed, we'll most other TODOs in a different PR.
ngc92
added a commit
that referenced
this pull request
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive refactoring of our cuda eval template:
Now supports individual test cases and benchmarks, with corresponding commands.
At this point, the code is absolutely unpolished, but it serves to indicate what I'd like to achieve.
Still missing:
Long shots.
Q: