Fix atan2 implementation to behave like Javascript Math.atan2 #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647
Previously the following cases failed:
According to MDN
Math.atan2(y, x)returns a value between -PI and PI. According to OpenGLatan(y / x)returns a value between -PI/2 and PI/2 whileatan(y, x)returns a value between -PI and PI.The main fix was to change the
atansignature to take(y, x)instead of(y / x)and then to handle the casesMath.atan2(-1, 0),Math.atan2(1, 0),Math.atan(0, 0)because in OpenGLatanis undefined whenx = 0but defined in Javascript.Note:
atanarguments are passedyfirst and thenx. This caused me some confusion at first.