Skip to content

fix(worker): let the ConfigMap owner watch enqueue elastic state records #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thxCode merged 1 commit into from
Oct 6, 2026
Merged

fix(worker): let the ConfigMap owner watch enqueue elastic state records #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/worker/controllers/worker/model_deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,6 +2175,9 @@ func modelDeploymentOwns(obj ctrlcli.Object, md *workercore.ModelDeployment) boo
}

func modelDeploymentOwnedResource(obj ctrlcli.Object) bool {
if obj.GetLabels()[elasticOperationLabel] == "true" || obj.GetLabels()[elasticObservationLabel] == "true" {
return true
}
if !systemmeta.MatchResource(obj, ModelDeploymentResourceType) {
return false
}
Expand Down
6 changes: 5 additions & 1 deletion pkg/worker/controllers/worker/model_deployment_elastic_reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ import (
"gpustack.ai/gpustack/pkg/worker/elasticengine"
)

const modelDeploymentElasticWithdrawnAnnotation = "modeldeployment.gpustack.ai/elastic-withdrawn"
const (
modelDeploymentElasticWithdrawnAnnotation = "modeldeployment.gpustack.ai/elastic-withdrawn"
elasticObservationLabel = "gpustack.ai/elastic-observation"
)

// The internal observation document preserves independent values and a last proven width.
// A previous value only selects the next observation. It never authorizes an engine action.
Expand Down Expand Up @@ -98,6 +101,7 @@ func (r *ModelDeploymentReconciler) persistElasticObservation(
cm = &core.ConfigMap{
ObjectMeta: meta.ObjectMeta{
Name: modelDeploymentElasticObservationName(md), Namespace: md.Namespace,
Labels: map[string]string{elasticObservationLabel: "true"},
OwnerReferences: []meta.OwnerReference{{
APIVersion: workercore.GroupVersion.String(), Kind: "ModelDeployment",
Name: md.Name, UID: md.UID, Controller: elasticControllerRef(),
Expand Down
4 changes: 4 additions & 0 deletions pkg/worker/controllers/worker/model_deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,13 @@ func TestModelDeploymentOwnedResourceRequiresAResourceNote(t *testing.T) {
systemmeta.NoteResource(withoutNote, ModelDeploymentResourceType, nil)
wrongType := role.DeepCopy()
systemmeta.NoteResource(wrongType, "instances", nil)
elasticOperation := &core.ConfigMap{ObjectMeta: meta.ObjectMeta{Labels: map[string]string{elasticOperationLabel: "true"}}}
elasticObservation := &core.ConfigMap{ObjectMeta: meta.ObjectMeta{Labels: map[string]string{elasticObservationLabel: "true"}}}

assert.True(t, modelDeploymentOwnedResource(role))
assert.True(t, modelDeploymentOwnedResource(router))
assert.True(t, modelDeploymentOwnedResource(elasticOperation))
assert.True(t, modelDeploymentOwnedResource(elasticObservation))
assert.False(t, modelDeploymentOwnedResource(withoutNote))
assert.False(t, modelDeploymentOwnedResource(wrongType))
}
Expand Down
Loading