Skip to content

fix(worker): enforce Elastic EP scale-up-only API - #742

Merged
thxCode merged 2 commits into
mainfrom
feat/elastic-ep-scale-up-recovery
Oct 7, 2026
Merged

thxCode merged 2 commits into
mainfrom
feat/elastic-ep-scale-up-recovery

Conversation

@thxCode

@thxCode thxCode commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug
/kind enhancement
/kind api-change
/area worker

What this PR does / why we need it:

  • Enforces the released Elastic EP API contract: width updates may stay unchanged or increase; a decrease is rejected by admission.
  • Recovers an unsent resize record when every captured member identity has disappeared, after proving the replacement native world.
  • Rebuilds a fresh operation when the proven live width still differs from the desired width.
  • Regenerates API descriptions and updates the Elastic EP guide and S1/S2 Specs to record the scale-up-only release boundary.

Which issue(s) this PR links to:

Addresses #741

Special notes for your reviewer:

  • Scale-down remains outside this release and is tracked separately in issue enhancement: support Elastic EP scale-down #741.
  • Recovery is fail-closed: partial identity survival and same-generation replacement continue to hold.
  • go test ./pkg/worker/webhooks/worker -count=1 passes.
  • go test ./pkg/worker/controllers/worker -count=1 passes.
  • make lint and the focused worker/webhook package tests pass on this branch. make lint docs is unchanged from the prior green commit and will rerun in CI.
  • W10 PASS-5 physical evidence is recorded separately. The inherited stale downward operation was root-caused, and S9/S11/R20 are not claimed as completed by this PR.

Does this PR introduce a user-facing change?

Elastic EP width updates now accept unchanged values and scale-up only; width decreases are rejected by admission.

@gpustack-code-review

gpustack-code-review Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

Reviewed ee3ddee..de58c14 only; earlier commits in this PR were reviewed in a previous run.

@thxCode
thxCode marked this pull request as ready for review October 7, 2026 06:18
@thxCode
thxCode merged commit 73e353c into main Oct 7, 2026
10 checks passed
@thxCode
thxCode deleted the feat/elastic-ep-scale-up-recovery branch October 7, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant