Repository navigation
fix(deviceplugin): combine kubelet resource device blocks - #745
Merged
Merged
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area devicemanager
What this PR does / why we need it:
Kubelet can report a two-card container as two
ContainerDevicesblocks for the same resource. Allocation verification compared each one-card block with the complete Pod annotation. This falsely reported an identity conflict and blocked subsequent allocations on the node.Combine device IDs from all blocks of the same container and resource before verification. Keep annotation comparison and unknown-device refusal unchanged.
Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
make lint, and the fullmake testsuite passed. The full suite ran in a clean checkout of this commit.Does this PR introduce a user-facing change?