Repository navigation
Conversation
- Change modelDeploymentRouterHTTPPort and Envoy listener port_value from 8081 to 8000 so routed and unrouted ModelDeployments both expose port 8000 on status.endpoint. - Update router, controller, and extension API unit tests to assert port 8000. Task 1 of model-deployment-unify-port-8000. Signed-off-by: thxCode <thxcode0824@gmail.com>
…ses and walkthroughs - Update e2e router cases (71, 91, 94, 120, 121) and walkthroughs (epd, external-dp) from port 8081 to 8000. - Index the port 8000 unification spec in docs/README.md. Task 2 of model-deployment-unify-port-8000. Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 5 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/area worker
What this PR does / why we need it:
ModelDeploymentpreviously used two different default HTTP ports for inference traffic: role Pods andService/<md>defaulted to port8000(modelDeploymentDefaultPort = 8000), while managed routers (llm-d-router,vllm-router, andsglang-gateway) andService/<md>-routerlistened on port8081(modelDeploymentRouterHTTPPort = 8081).This PR moves the managed router HTTP port from
8081to8000so that both unrouted (http://<md>.<ns>.svc:8000) and routed (http://<md>-router.<ns>.svc:8000) deployments expose port8000onstatus.endpointby default:pkg/worker/controllers/worker,pkg/worker/kvcache/router,pkg/worker/extensionapis/worker): SetmodelDeploymentRouterHTTPPort = 8000and Envoy static listenerport_value: 8000inmodelDeploymentRouterEnvoyConfig, and update unit tests across router, controller, and extension API packages..agents/skills/gpustack-operator-e2e,docs/,specs/): Update end-to-end test cases (case-71.sh,case-91.sh,case-94.sh,case-120.sh,case-121.sh) and walkthroughs (epd.md,external-dp.md) to port8000, and add the specification inspecs/2026-10-18-model-deployment-unify-port-8000.md.Which issue(s) this PR links to:
Fixes #764
Special notes for your reviewer:
make lint agents-shellandmake lint docspass with 0 errors.pkg/worker/kvcache/router,pkg/worker/controllers/worker, andpkg/worker/extensionapis/workerpass under-race.Does this PR introduce a user-facing change?