Repository navigation
docs: replace engine.version with engine.image in examples - #774
Merged
Merged
Conversation
ModelDeploymentEngine has no version field; the examples now name a gpustack/runner image. Signed-off-by: thxCode <thxcode0824@gmail.com>
thxCode
force-pushed
the
docs/engine-image-in-examples
branch
from
October 19, 2026 12:40
342f0d3 to
fcbd514
Compare
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
📄
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/area worker
What this PR does / why we need it:
ModelDeploymentEngineno longer has aversionfield. It carriesnameand a requiredimage, andengine-versions.mdalready says so. The README and five walkthroughs still showedengine.version: "0.29.0", so copying them gave an invalid manifest.engine.version: "0.29.0"withengine.image: gpustack/runner:cuda13.0-vllm0.29.0inREADME.mdand six places across five pages underdocs/walkthroughs/.Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
make lint docspasses.Does this PR introduce a user-facing change?