Fix SafeDirectoryUpdater when running in a layered container build. #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
eregon
reviewed
Dec 9, 2025
Contributor
eregon
left a comment
eregon
left a comment
There was a problem hiding this comment.
Thank you for the fix!
I suppose the mirroring deleted the branch, doesn't matter much to me as long as it's merged to master :)
| try: | ||
| os.rename(self.target, old_target) | ||
| except OSError as e: | ||
| if e.errno == 18: # invalid cross-device link |
Contributor
There was a problem hiding this comment.
The errno seems to be EXDEV (matches from the man page and the value on Linux),
so this could be if e.errno == errno.EXDEV: # invalid cross-device link
Member
Author
|
Yes, something is weird with our bot. I'll merge it with an internal PR. |
Member
Author
|
Merged as 61380fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the root cause of #295.