Fixes the issue that nativeTest cannot be executed using Junit 5.11.0-M2 #603
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linghengqian
commented
Jun 13, 2024
•
linghengqian
commented
- Fixes Unable to execute nativeTest under Junit 5.11.0-M2 #602 .
- Fixes the issue that nativeTest cannot be executed using Junit 5.11.0-M2.
- The project's gradle toolchain actively looks for a random jdk17 release, such as Microsoft OpenJDK 17. Setting up a GraalVM version of JDK11 can be very confusing.
oracle-contributor-agreement
bot
added
the
OCA Verified
This was referenced Jun 13, 2024
linghengqian
force-pushed
the
fix-junit
branch
2 times, most recently
from
43a5d98
to
581246b
Compare
linghengqian
force-pushed
the
fix-junit
branch
3 times, most recently
from
219cf50
to
963e4c5
Compare
linghengqian
force-pushed
the
fix-junit
branch
2 times, most recently
from
611dc68
to
fe745c6
Compare
linghengqian
force-pushed
the
fix-junit
branch
2 times, most recently
from
419e583
to
2dcfe2f
Compare
linghengqian
commented
Jun 14, 2024
There was a problem hiding this comment.
- @dnestoro @fniephaus Is it possible to temporarily disable the execution of
./gradlew :native-gradle-plugin:functionalTeston GraalVM CE Dev For JDK24 / https://github.com/graalvm/graalvm-ce-dev-builds/releases/tag/24.1.0-dev-20240612_2110 ? I cannot reproduce the CI results of Github Actions locally, refer to https://github.com/graalvm/native-build-tools/actions/runs/9517556127/job/26236415815?pr=603 .
sdk install java 17.0.11-graal
sdk use java 17.0.11-graal
git clone [email protected]:linghengqian/native-build-tools.git -b fix-junit
cd ./native-build-tools/
./gradlew :native-gradle-plugin:functionalTest
2ee0a26
to
10fb62e
Compare
vjovanov
reviewed
Jul 2, 2024
.sdkmanrc
Outdated
| @@ -1,3 +1,3 @@ | |||
| # Enable auto-env through the sdkman_auto_env config | |||
| # Add key=value pairs of SDKs to use below | |||
| java=22.2.r11-grl | |||
| java=17.0.11-graal | |||
There was a problem hiding this comment.
- I initialized a new Ubuntu WSL distribution instance to test the current project, and it turns out that the project requires both GraalVM CE For JDK11 and GraalVM CE For JDK22 to be installed via SDKMAN! to run unit tests. I will roll back this change.
vjovanov
reviewed
Jul 2, 2024
| @@ -89,7 +89,7 @@ jobs: | |||
| - name: "🔧 Install GraalVM (dev)" | |||
| uses: graalvm/setup-graalvm@main | |||
| with: | |||
| java-version: 'dev' | |||
| java-version: '22.0.1' | |||
There was a problem hiding this comment.
- This is related to the issue I pointed out at Fixes the issue that nativeTest cannot be executed using Junit 5.11.0-M2 #603 (review) . Under GraalVM CE For JDK24 Dev, this CI fails as https://github.com/graalvm/native-build-tools/actions/runs/9517556127/job/26236415815?pr=603 . This CI works fine under GraalVM CE For JDK22, as shown in https://github.com/graalvm/native-build-tools/actions/runs/9520173469/job/26244879976?pr=603 . I don't know anything about the changes after JDK23.
- I have now rolled back the changes to show the CI.
dnestoro
approved these changes
Jul 2, 2024
|
@linghengqian let me try to fix failing gate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.