Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zoom & pan logic in gr.ImageEditor #9155

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Aug 20, 2024

Description

Keeping this in draft to focus on redesign. Logic is here to test out and feedback so far though 🔍

Do we think this should be implemented in gr.Image?

Closes: #3278

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@hannahblair hannahblair changed the title implement zoom/pan logic Implement zoom & pan logic in gr.ImageEditor Aug 20, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 20, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/7d81faed8b9df7accff5c640d827b903372a9fff/gradio-4.41.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@7d81faed8b9df7accff5c640d827b903372a9fff#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/7d81faed8b9df7accff5c640d827b903372a9fff/gradio-client-1.5.0.tgz

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/icons minor
@gradio/imageeditor minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Implement zoom & pan logic in gr.ImageEditor

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Oct 3, 2024

Can we close this @hannahblair and revisit after 5.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ImageEditor] - Zoomable Image components for better UX
3 participants