add(helm): Use commonLabels in chart #4573
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kalleep
reviewed
Oct 9, 2025
Comment on lines
+13
to
+21
| 1.3.1 (2025-10-08) | ||
| ---------- | ||
|
|
||
| ### Other changes | ||
|
|
||
| - Update values to use commonLabels | ||
|
|
||
| ------------------ | ||
|
|
There was a problem hiding this comment.
You should not create a new version but put this entry under Unreleased
kalleep
reviewed
Oct 9, 2025
Comment on lines
+204
to
+206
| # -- Add additional label to all resources | ||
| commonLabels: {} | ||
|
|
There was a problem hiding this comment.
This feels like the wrong place to put this, everything else under controller will only affect e.g. daemonset, statefulset etc but this would affect all resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces the use of the commonLabels field in the Alloy Helm chart.
It allows users to define a common set of labels that will be applied to all resources generated by the chart (Deployments, Services, ConfigMaps, etc.), ensuring consistent metadata and easier resource management.
Key Changes
Added the new field commonLabels in values.yaml.
Updated Helm template helpers to render commonLabels across all chart resources.
Updated documentation (README.md) to describe the new value.
Bumped chart version to 1.3.1.
Updated CHANGELOG.md accordingly.
Example Usage:
This will apply the above labels to all resources created by the chart.
Benefits
Enables better alignment with GitOps practices and resource tracking.
Simplifies applying organization-wide labels such as team, environment, or owner.
Improves observability and filtering across Kubernetes and monitoring tools.
Which issue(s) this PR fixes
N/A
PR Checklist