loki: safe apis for send and recv between components #4586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
reviewed
Oct 9, 2025
| Send(context.Context, Entry) error | ||
| Recv(context.Context) (Entry, error) |
Contributor
There was a problem hiding this comment.
I think the only possible error you can get here is when context is cancelled. So maybe we should return bool and treat is as continue sending / receiving when true or stream is closed / no more data when false.
Contributor
Author
There was a problem hiding this comment.
Yes we can go with bool. I was thinking that in the future this could change but currently we only need a signal that we should stop sending / receiving so bool is fine
kalleep
force-pushed
the
kalleep/loki-rec-safe-send
branch
from
36851ed to
ac69b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist