enhance stage.luhn to support numbers with delimiters #4588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: |
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
kalleep
reviewed
Oct 20, 2025
| The `source` field defines the source of data to search. | ||
| When `source` is missing or empty, the stage parses the log line itself, but it can also be used to parse a previously extracted value. | ||
|
|
||
| If you want the Luhn algorithm to identify numbers with delimiters, for example `4032-0325-1354-8443`, you can configure the `delimiters` field with the expected delimiters. |
There was a problem hiding this comment.
Would be nice to have an example for this
|
💻 Deploy preview deleted (enhance stage.luhn to support numbers with delimiters). |
kalleep
approved these changes
Oct 22, 2025
clayton-cornell
approved these changes
Oct 22, 2025
clayton-cornell
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Previously, stage.luhn could not capture credit card numbers with dashes, for example, this PR adds support for those use cases.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist