-
Notifications
You must be signed in to change notification settings - Fork 457
Loki Write: Remove Internal Labels #4601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9125af2 to
536cf2a
Compare
|
Is there a specific reason why I don't see a reason why |
|
I thought because an |
536cf2a to
4e3da08
Compare
|
Updated to remove |
f6105ff to
fc2b42d
Compare
fc2b42d to
f60a60d
Compare
263134f to
0ff2d38
Compare
e349b50 to
93bb8f2
Compare
|
After thinking about this a bit I think we should not do this directly in the component but here instead https://github.com/grafana/alloy/blob/main/internal/component/common/loki/client/batch.go#L116 Pretty sure we can just remove the |
ca31f05 to
5b054a4
Compare
5b054a4 to
1353463
Compare
This change is to add logic so that labels that start with `__` are filtered out, unless they are `externalLabels`. Labels that start with `__` are used internally for things such as metadata. If a user want to preserve the contents of one of these internal labels, then can do so using relabelling to remove the `__`. This change also adds tests which check various different scenarios
1353463 to
bfbc0b9
Compare
PR Description
This change is to add logic so that labels that start with
__are filtered out. Labels that start with__are used internally for things such as metadata. If a user want to preserve the contents of one of these internal labels, then can do so using relabelling to remove the__.This change also adds tests which check various different scenarios.
Which issue(s) this PR fixes
Fixes #4412
Notes to the Reviewer
The docs already state that labels with
__get removed, so I don't see the need to update these.PR Checklist