database_observability: use query_start as a key instead of xid for query samples, removing idle state entries #4602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaantunes
requested review from
cristiangreco,
fridgepoet and
matthewnolf
as code owners
gaantunes
changed the title
gaantunes
changed the title
gaantunes
changed the title
gaantunes
changed the title
rgeyer
approved these changes
Oct 20, 2025
internal/component/database_observability/postgres/collector/query_samples.go
Outdated
Show resolved
Hide resolved
internal/component/database_observability/postgres/collector/query_samples.go
Show resolved
Hide resolved
matthewnolf
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In Postgres, the xid is lazily assigned, so while a query may show up in
pg_stat_activity, it will only be assigned a xid when it affectively touches or locks data. Plus, not all queries are transactions.This is migrating to use query_start instead of xid as the sample event keys.
Also remove
idlestate events altogether, since we need to track specificallyidle in transactionandidle in transaction (aborted), which is covered.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist