feat(loki.source.podlogs): add preserve_discovered_labels option #4606
+153
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new preserve_discovered_labels parameter to loki.source.podlogs component that allows discovered Kubernetes metadata labels to be preserved and forwarded to downstream components like loki.relabel. When enabled, this option preserves __meta_kubernetes_* labels that would normally be stripped after relabeling, enabling component chaining where pod metadata can be accessed by downstream relabeling components. Fixes grafana#2526
QuentinBisson
requested review from
a team and
clayton-cornell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a new preserve_discovered_labels parameter to loki.source.podlogs component that allows discovered Kubernetes metadata labels to be preserved and forwarded to downstream components like loki.relabel.
When enabled, this option preserves _meta_kubernetes* labels that would normally be stripped after relabeling, enabling component chaining where pod metadata can be accessed by downstream relabeling components.
Which issue(s) this PR fixes
Fixes #2526
Notes to the Reviewer
Because loki.write drops any labels that starts with
__but the__tenant_id_label, this should not impact downstream Loki but would definitely helploki.source.podlogsusers/PR Checklist