faro.receiver: add sourcemap fetching from remote locations #4614
+323
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
Oxel40
force-pushed
the
faro-fetch-sourcemaps-from-remote
branch
from
48dd657 to
688f75f
Compare
Oxel40
force-pushed
the
faro-fetch-sourcemaps-from-remote
branch
from
688f75f to
9c9fb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This adds the ability to fetch sourcemaps from remote locations over HTTP to the
faro.receiver. Allowingsourcemaps > locationblocks to point to an HTTP URL as the path, e.g.,path = "https://foo.com/blob/sourcemaps/".The motivation behind this feature is to support the use case where your frontend is served by an external CDN and Alloy is running on internal infrastructure, where external resources are not readily accessible, and managing and attaching volumes to the Alloy container is complex or undesired. This feature allows you to host your sourcemaps internally, e.g., on a blob storage service. It also fits the use case where you don't want to expose sourcemaps to customers but still want to be able to fetch them internally for
faro.receiver's stack-trace transformations.If multiple location blocks are defined, blocks pointing to on-disk paths will be checked first before attempting to fetch the sourcemaps over HTTP.
Which issue(s) this PR fixes
None.
Notes to the Reviewer
None.
PR Checklist