Fix slicelabels tests with timeouts #4650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: piotr.gwizdala <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
|
thampiotr
added a commit
that referenced
this pull request
Oct 23, 2025
* WIP: Upgrade Prometheus to v3.7.1 with compatibility fixes - Updated Prometheus to v1.8.2-0.20251020143145-59659a23710a (staleness_disabling_v3.7.1 branch) - Upgraded Loki to branch with otlptranslator v1.0.0 support and PreprocessExpr fixes - Pinned k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, and k8s.io/kube-openapi to v0.32.6 versions to maintain networking/v1alpha1 API compatibility and fix structured-merge-diff v4/v6 conflicts - Fixed Mimir rulefmt.Validate to use model.UTF8Validation parameter - Removed otlptranslator replace directive (now using v1.0.0) Known issues requiring manual resolution: 1. yaml.v3 import path mismatch in k8s.io/kube-openapi (go.yaml.in vs gopkg.in) 2. OTel collector pprofile API breaking changes in debugexporter and ottl packages * Fix errors * fix pdata issue * fix issue with k8s clients * fix code issues from changes upstream * fix semconv version * fix validation schemes in tests * fix more tests * Fix slicelabels test and CI issues (#4639) * change loki version * add missing slicelabels * fix memory corruption in loki wal * more fixes * fix converters * Refactor: Use labels.FromStrings for label creation (#4650) Co-authored-by: Cursor Agent <[email protected]> * fix linter build tags * clean up and fix lint * Fix build tags in alloylint * PR comments * PR comments --------- Co-authored-by: Cursor Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Resolves build and lint failures when the
slicelabelsbuild tag is enabled. Thelabels.Labelstype, whenslicelabelsis active, is a struct, makingappend()an invalid operation for label creation. Updatedinternal/service/labelstore/service_test.goto uselabels.FromStrings()for correct label initialization.Which issue(s) this PR fixes
Addresses CI lint failures observed in #4636.
Notes to the Reviewer
This fix ensures
internal/service/labelstore/service_test.gocorrectly initializeslabels.Labelswhen built with theslicelabelstag, resolving issues withgo test -tags slicelabels ./....PR Checklist