feat: Add new component loki.source.string #4701
Open
+265
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ravishankar15
force-pushed
the
loki-string
branch
from
c85399a to
11cd4f8
Compare
ravishankar15
requested review from
a team and
clayton-cornell
as code owners
ravishankar15
force-pushed
the
loki-string
branch
from
11cd4f8 to
401e71f
Compare
clayton-cornell
added
the
type/docs
Update documentation and changelog fix docs
ravishankar15
force-pushed
the
loki-string
branch
from
401e71f to
1c672bd
Compare
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Contributor
|
Docs look OK, over to the dev team now for code review. |
ptodev
reviewed
Nov 5, 2025
Contributor
ptodev
left a comment
ptodev
left a comment
There was a problem hiding this comment.
Hi @ravishankar15, thank you for opening a PR! I'm personally happy to have such a component.
It'd be good if @dehaansa also reviews this PR, because he's been working on something similar in #4555. It's a more general component which reuses the Grafana Infinity Data Source.
| - ../loki.source.string/ # /docs/alloy/latest/reference/components/loki.source.string/ | ||
| description: Learn about loki.string | ||
| labels: | ||
| stage: general-availability |
Contributor
There was a problem hiding this comment.
I think this is ok, since it's quite a simple component 🤔 Normally we'd want to start as an experimental and then make it GA in a release or two.
Co-authored-by: Paulin Todev <[email protected]>
Contributor
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
I think this was missed :-)
| canonical: https://grafana.com/docs/alloy/latest/reference/components/loki/loki.source.string/ | ||
| aliases: | ||
| - ../loki.source.string/ # /docs/alloy/latest/reference/components/loki.source.string/ | ||
| description: Learn about loki.string |
Contributor
There was a problem hiding this comment.
Suggested change
| description: Learn about loki.string | |
| description: Learn about loki.source.string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #347
Notes to the Reviewer
PR Checklist