feat(loki.process): add regex field to logfmt and json stages #4941
+203
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
Contributor
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
Really minor suggestion. Otherwise the docs look fine. Over to the dev team for code review.
timonegk
force-pushed
the
logfmt-json-regex
branch
from
c68961b to
2257af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
After I added the
regexfield to thestructured_metadatastage in #4629, this PR adds the field tologfmtandjsonas well. As pointed out by @bmundt6 in #2156 (comment), this is required to fully close #2156.Which issue(s) this PR fixes
Continues the fix for #2156.
Notes to the Reviewer
In the documentation, I removed the section about the logfmt-parser preserving the type of booleans and numbers because these types are actually always converted to strings.
PR Checklist