Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auto detecting TCX #1533

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Add support for auto detecting TCX #1533

merged 6 commits into from
Jan 16, 2025

Conversation

rafaelroquetto
Copy link
Contributor

Add a configuration option called BEYLA_BPF_TC_BACKEND=auto, which tells Beyla to query the underlying kernel for TCX support. If TCX is supported, Beyla will use that, falling back to TC/Netlink otherwise.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 71.15385% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (bf091bb) to head (f8b07b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/ebpf/tcmanager/tcmanager.go 68.75% 13 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
- Coverage   71.67%   71.64%   -0.04%     
==========================================
  Files         195      195              
  Lines       19409    19459      +50     
==========================================
+ Hits        13911    13941      +30     
- Misses       4823     4841      +18     
- Partials      675      677       +2     
Flag Coverage Δ
integration-test 53.72% <71.15%> (-0.20%) ⬇️
k8s-integration-test 54.08% <71.15%> (-0.61%) ⬇️
oats-test 30.89% <1.92%> (-0.09%) ⬇️
unittests 47.26% <1.92%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sweet!

rafaelroquetto and others added 2 commits January 15, 2025 17:06
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
@rafaelroquetto rafaelroquetto merged commit b9eaba8 into main Jan 16, 2025
15 checks passed
@rafaelroquetto rafaelroquetto deleted the detect_tcx branch January 16, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants