Add the ability to sync AlertManager configuration with Cortex #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
requested changes
Dec 9, 2020
| @@ -13,6 +13,8 @@ This action is configured using environment variables defined in the workflow. T | |||
| | `CORTEX_API_KEY` | Optional password that is required for password protected Cortex clusters. An encrypted [github secret](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets ) is recommended. | `false` | N/A | | |||
| | `ACTION` | Which action to take. One of `lint`, `prepare`, `check`, `diff` or `sync` | `true` | N/A | | |||
| | `RULES_DIR` | Comma-separated list of directories to walk in order to source rules files | `false` | `./` | | |||
| | `COMPONENT` | `RULER` or `ALERTMANAGER`. This dictates whether to sync ruler rulegroups or AlertManager configurations | `true` | N/A | | |||
| | `ALERTMANAGER_CONFIG_PATH` | Path to the tenants AlertManager configuration | `true` If `COMPONENT` is set to `ALERTMANAGER` | `./alertManager.yml` | |||
There was a problem hiding this comment.
I think it's missing a | at the end, in the diff, it looks like one column instead of two - am I missing something?
| if [ -z "${RULES_DIR}" ]; then | ||
| echo "RULES_DIR not set, using './' as a default." | ||
| RULES_DIR="./" | ||
| fi | ||
|
|
||
| if [ ${COMPONENT} == "ALERTMANAGER" ] && [ -z "${ALERTMANAGER_CONFIG_PATH}" ]; then | ||
| echo "No ALERTMANAGER_CONFIG_PATH variable set. Defaulting to ./alertManager.yml" |
There was a problem hiding this comment.
Suggested change
| echo "No ALERTMANAGER_CONFIG_PATH variable set. Defaulting to ./alertManager.yml" | |
| echo "ALERTMANAGER_CONFIG_PATH not set, using ./alertmanager.yml as a default." |
| if [ -z "${RULES_DIR}" ]; then | ||
| echo "RULES_DIR not set, using './' as a default." | ||
| RULES_DIR="./" | ||
| fi | ||
|
|
||
| if [ ${COMPONENT} == "ALERTMANAGER" ] && [ -z "${ALERTMANAGER_CONFIG_PATH}" ]; then | ||
| echo "No ALERTMANAGER_CONFIG_PATH variable set. Defaulting to ./alertManager.yml" | ||
| ALERTMANAGER_CONFIG_PATH=./alertManager.yml |
There was a problem hiding this comment.
Suggested change
| ALERTMANAGER_CONFIG_PATH=./alertManager.yml | |
| ALERTMANAGER_CONFIG_PATH=./alertmanager.yml |
Comment on lines
+31
to
+32
| echo "COMPONENT not set, select either RULER or ALERTMANAGER" | ||
| exit 1 |
There was a problem hiding this comment.
Suggested change
| echo "COMPONENT not set, select either RULER or ALERTMANAGER" | |
| exit 1 | |
| echo "COMPONENT not set, using RULER as a default." | |
| COMPONENT=RULER |
There was a problem hiding this comment.
This would make sure we do not break existing setups.
| ;; | ||
| esac | ||
| elif [ "${COMPONENT}" == "ALERTMANAGER" ]; then | ||
| OUTPUT=$(/usr/bin/cortextool alertmanager load ${ALERTMANAGER_CONFIG_PATH}) |
There was a problem hiding this comment.
Do you have time to add the other commands just like the previous block?
| ;; | ||
| esac | ||
| elif [ "${COMPONENT}" == "ALERTMANAGER" ]; then | ||
| OUTPUT=$(/usr/bin/cortextool alertmanager load ${ALERTMANAGER_CONFIG_PATH}) |
There was a problem hiding this comment.
Suggested change
| OUTPUT=$(/usr/bin/cortextool alertmanager load ${ALERTMANAGER_CONFIG_PATH}) | |
| verifyTenantAndAddress | |
| OUTPUT=$(/usr/bin/cortextool alertmanager load ${ALERTMANAGER_CONFIG_PATH}) |
| OUTPUT=$(/usr/bin/cortextool alertmanager load ${ALERTMANAGER_CONFIG_PATH}) | ||
| STATUS=$? | ||
| else | ||
| echo "Invalid component selected, use RULER or ALERTMANAGER" |
There was a problem hiding this comment.
Suggested change
| echo "Invalid component selected, use RULER or ALERTMANAGER" | |
| echo "COMPONENT is not valid, please use RULER or ALERTMANAGER." |
| STATUS=$? | ||
| ;; | ||
| $PRINT_CMD) | ||
| OUTPUT=$(/usr/bin/cortextool rules print "$@") |
There was a problem hiding this comment.
Suggested change
| OUTPUT=$(/usr/bin/cortextool rules print "$@") | |
| verifyTenantAndAddress | |
| OUTPUT=$(/usr/bin/cortextool rules print "$@") |
|
RyanW8 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.