-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge for #181 #208
base: main
Are you sure you want to change the base?
Merge for #181 #208
Conversation
… if matchers use vars
…of configfile settings
…k with single test run and full package run
… feat/custom-target-matcher-check
@alex5517, if you have a second to look this over. I'll get it merged ASAP. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I made some changes to the original PR #181 which might be good to have included here (Had not seen this PR). It does look like an issue was introduced with PR: #205 I did not fully investigate the root cause of this issue... but the dashboard-linter is no longer able to parse some dashboards:
I noticed this new error when linting one of the dashboards provided by mimir-mixin https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-compiled/dashboards/mimir-compactor.json Also wanna mention that there is an issue present both in this and the other PR with autofix
I was planning to have a look at it, just haven't got around to it... |
@alex5517 , I think using https://github.com/grafana/grafana-foundation-sdk/ in #205 caused some old Dashboards not to parse. Would try to address it. |
This is a superset of #181 which includes recent changes/updates to main.
It also updates the docs (as soon as I finish that, I realized it was needed while writing this PR).