Implement UNIX socket support for gRPC and HTTP listeners #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR resolves an issue when trying to set the
HTTPListenNetwork
orGRPCListenNetwork
config values tounix
where a port would be appended to the file path, preventing the socket from being bound.As an example, take this configuration:
This would lead to a listener being created for
unix:///var/run/http.sock:80
, including the default value for theHTTPListenPort
,:80
.This PR adds a brief check to see if the network is
unix
and if so, removes the port from the address, leading to the correct address being bound (unix:///var/run/http.sock
).Which issue(s) this PR fixes:
Fixes #475
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]