make WriteTo non-blocking #525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
May 15, 2024
Comment on lines
+435
to
+439
| t.writeCh <- struct{}{} | ||
| go func() { | ||
| defer func() { <-t.writeCh }() | ||
| t.writeToAsync(b, addr) | ||
| }() |
There was a problem hiding this comment.
Instead of starting new goroutine for each write, shall we have a pool of writing goroutines, and pass them messages to write via channel?
pstibrany
reviewed
May 15, 2024
| @@ -426,7 +432,15 @@ func (t *TCPTransport) getAdvertisedAddr() string { | |||
| func (t *TCPTransport) WriteTo(b []byte, addr string) (time.Time, error) { | |||
| t.sentPackets.Inc() | |||
| t.sentPacketsBytes.Add(float64(len(b))) | |||
| t.writeCh <- struct{}{} | |||
There was a problem hiding this comment.
Is WriteTo only called from single goroutine? If not, it just became more blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR makes the WriteTo function non-blocking, and adds a configurable maximum writes parameter to control concurrency.
Which issue(s) this PR fixes:
#192
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]