Fix: GetPackageExports works regardless of version #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug due to grafana npm packages < 9.2 not having a
distdirectory which was causing the lint rule to not report warnings as it silently failed to find types files. Additionally initial linting is greatly sped up if the version passed is > 9.2.Locally, running the tests that pull the packages(cold cache) now pass in ~2.5s. Doing the same against
maincurrently takes ~30s locally as npm installs 350 packages. CI test step drops from ~22s to ~12s. 🚀This PR addresses the following issues:
${tmpDir}/node_modules/${pkg}/index.d.ts.cdn.jsdelivr.netrather than use npm to install the package and all its dependencies.