Fix: Fix panicking when file cannot be opened or is empty (#173)

* better log error handling (cherry picked from commit 3d17f76) * Update receiver/githubactionsreceiver/log_event_handling.go Co-authored-by: Horst Gutmann <[email protected]> * Update receiver/githubactionsreceiver/log_event_handling.go Co-authored-by: Horst Gutmann <[email protected]> --------- Co-authored-by: Giordano Ricci <[email protected]> Co-authored-by: Horst Gutmann <[email protected]>
grafana · Nov 19, 2024 · f796444 · f796444
1 parent 31da4e7
commit f796444
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/receiver/githubactionsreceiver/log_event_handling.go b/receiver/githubactionsreceiver/log_event_handling.go
@@ -7,6 +7,7 @@ import (
 	"archive/zip"
 	"bufio"
 	"context"
+	"fmt"
 	"io"
 	"net/http"
 	"os"
@@ -64,9 +65,16 @@ func eventToLogs(event interface{}, config *Config, ghClient *github.Client, log
 			return nil, err
 		}
 
-		archive, _ := zip.OpenReader(out.Name())
+		archive, err := zip.OpenReader(out.Name())
+		if err != nil {
+			return nil, fmt.Errorf("failed to open zip file: %w", err)
+		}
 		defer archive.Close()
 
+		if archive.File == nil {
+			return nil, fmt.Errorf("archive is empty")
+		}
+
 		// steps is a map of job names to a map of step numbers to file names
 		var jobs = make([]string, 0)
 		var files = make([]*zip.File, 0)