Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: convert compositions to pipeline mode #12

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

Duologic
Copy link
Member

@Duologic Duologic commented Dec 9, 2024

The legacy 'Resources' mode is being deprecated in favor of the new 'Pipeline' mode. This PR converts the Compositions to that mode. From upstream docs:

Crossplane has two modes of composition:

  • mode: Pipeline
  • mode: Resources

Use the Pipeline mode to use composition functions.

The Resources mode is deprecated, and you shouldn’t use it. Crossplane supports Compositions that use the Resources mode for backward compatibility, but the feature is no longer maintained. Crossplane doesn’t accept new Resources features, and only accepts security bug fixes.

mode: Resources is technically the same as when 'mode' is not defined, which matches how the Compositions were rendered before this PR.

This PR will also bump the minor version to indicate something breaking is changing, keeping major at zero to indicate this is still experimental and new.

@Duologic Duologic requested a review from a team December 9, 2024 21:18
@Duologic Duologic changed the title duologic/convert to pipeline mode fix!: convert compositions to pipeline mode Dec 9, 2024
@Duologic Duologic merged commit 4e2350a into main Dec 12, 2024
2 checks passed
@Duologic Duologic deleted the duologic/convert_to_pipeline_mode branch December 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants