Feature: Dedicated structs for Shared/Common options #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
common_opts_structs
branch
from
9d89880
to
1d93037
Compare
Baarsgaard
force-pushed
the
common_opts_structs
branch
from
7b71e6f
to
07511b5
Compare
Baarsgaard
force-pushed
the
common_opts_structs
branch
from
07511b5
to
7fc787c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to open this draft in order to better illustrate what I meant with a common options struct, specifically:
ResyncPeriodInstanceSelectorAllowCrossNamespaceImportNotice that the CRDs have not changed at all, except for the descriptions and the default value for
ResyncPeriodon some resources, the only exception beingGrafanaNotificationPolicywhich now has aAllowCrossNamespaceImportfieldFrom what I can tell, this does not clash with using Interfaces for ensuring functions are defined for structs.
I included the
GrafanaCommonStatusstruct with a partial implementation as well in the second commit.The expectation is that this one would help simplify the implementation of Statuses across CRDs (Conditions and more)
I fully expect this to not get merged in case you do not want to go in this direction.