[tempo-distributed] add log_discarded_spans config for Tempo distributor to tempo-distrib… #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dastrobu
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
dastrobu
commented
Aug 26, 2024
charts/tempo-distributed/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: tempo-distributed | |||
| description: Grafana Tempo in MicroService mode | |||
| type: application | |||
| version: 1.17.0 | |||
| version: 1.18.0 | |||
| appVersion: 2.5.0 | |||
There was a problem hiding this comment.
the app version should be bumped, when it is clear which release log_discarded_spans will be part of. Check the CHANGELOG.md for
[FEATURE] Discarded span logging log_discarded_spans grafana/tempo#3957 (@dastrobu)
dastrobu
changed the title
dastrobu
force-pushed
the
tempo-distributed/log_discarded_spans
branch
2 times, most recently
from
a8dfa7b
to
05dc6e4
Compare
…uted chart.
The new value enabled configuring `log_discarded_spans` like for `log_received_spans` as shown below:
```
distributor:
config:
log_discarded_spans:
enabled: true
log_received_spans:
# ...
```
The feature was introduced in [tempo/#3964](grafana/tempo#3964).
Signed-off-by: Daniel Strobusch <[email protected]>
dastrobu
force-pushed
the
tempo-distributed/log_discarded_spans
branch
from
8ec625d
to
d490b55
Compare
Sheikh-Abubaker
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uted chart.
The new value enabled configuring
log_discarded_spanslike forlog_received_spansas shown below:The feature was introduced in grafana/tempo#3964 and relates to grafana/tempo#3957.