[lgtm-distributed] #3885 update all dependencies #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timberhill <[email protected]>
|
Hey @zanhsieh / @zalegrala, could you please review and approve the automation there? Tested in a local cluster for now. |
timberhill
changed the title
|
This needs another kick, sorry! |
|
@zanhsieh / @zalegrala I think it should be ready for approvals once the one workflow runs again 🙏 |
|
@zanhsieh / @zalegrala While it was sitting, it asked for branch update, so needs to run the workflows again and get two approvals. Let me know if there is a better approach to approvals and merging! |
|
It looks like the default port for the tempo query frontend has changed from 3100 to 3200 at some point, so trace metrics don't work with this chart as it stands In order to get this chart to work I've had to change the values for the data sources in values.yaml to :3200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3885