Skip to content

Conversation

@timberhill
Copy link
Contributor

@timberhill timberhill commented Sep 24, 2025

  • Uplift the dependency chart version to the latest ones available in the helm repo
  • Uplift the chart MAJOR version to reflect a major version bump in a dependency
  • Regenerate the README

Contributes to #3885

Fixes #3885

@timberhill timberhill requested a review from a team as a code owner September 24, 2025 11:39
@timberhill
Copy link
Contributor Author

Hey @zanhsieh / @zalegrala, could you please review and approve the automation there? Tested in a local cluster for now.

@timberhill timberhill changed the title #3885 update all dependencies [lgtm-distributed] #3885 update all dependencies Sep 29, 2025
@timberhill
Copy link
Contributor Author

This needs another kick, sorry!
Just updated the PR title

@timberhill
Copy link
Contributor Author

@zanhsieh / @zalegrala I think it should be ready for approvals once the one workflow runs again 🙏

@timberhill
Copy link
Contributor Author

@zanhsieh / @zalegrala While it was sitting, it asked for branch update, so needs to run the workflows again and get two approvals.

Let me know if there is a better approach to approvals and merging!

@danbrad
Copy link

danbrad commented Oct 2, 2025

It looks like the default port for the tempo query frontend has changed from 3100 to 3200 at some point, so trace metrics don't work with this chart as it stands

In order to get this chart to work I've had to change the values for the data sources in values.yaml to :3200

url: http://{{ .Release.Name }}-tempo-query-frontend:3100

@timberhill
Copy link
Contributor Author

Thanks @danbrad, well spotted! Pushed the fix.

@timberhill
Copy link
Contributor Author

@zanhsieh / @zalegrala Sorry to ping you again, but the PR is going out of date as we speak 😆
Is there a better way to request a review for something like this? If we want to keep this one in step with the dependencies for instance, it might get pretty tedious for you!

@zalegrala
Copy link
Contributor

@timberhill A ping here will usually get my attention within a couple days. I'm returning from a few days away, apologies for the delay. For more prompt review, you can ping me in the community slack.

@danieltharp
Copy link

Found this PR while looking at how out of date the referenced chart is and asked in the community Slack in #grafana-dev, no idea if that's the right place.

@jkroepke
Copy link
Collaborator

Hi,

you should assume that this chart this deprecated .

The dependencies like loki-distributed is deprecated , I guess the same belongs to mimir. Oncall itself is deprecated as well.

@hegerdes
Copy link

you should assume that this chart this deprecated .

Thought so too. I needed something quick for a project and this seemd like a good all in one thing.
Battled with the values till I relished that I was setting values for a newer sub chart that is not yet supported. Overriding dependency versions for sub-helm-charts is unfortunately not supported by helm.

Would be nice to update this, but keep in mind a new release will break a lot of peoples setups. Two major grafana version updates (bundled is v10, current is v12) changes in ports, config docs and values schema in sub-charts. Kind of a tricky situation

@Sheikh-Abubaker Sheikh-Abubaker merged commit 06629a0 into grafana:main Oct 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lgtm-distributed] is outdated

7 participants