-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[lgtm-distributed] #3885 update all dependencies #3912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: timberhill <[email protected]>
|
Hey @zanhsieh / @zalegrala, could you please review and approve the automation there? Tested in a local cluster for now. |
|
This needs another kick, sorry! |
|
@zanhsieh / @zalegrala I think it should be ready for approvals once the one workflow runs again 🙏 |
|
@zanhsieh / @zalegrala While it was sitting, it asked for branch update, so needs to run the workflows again and get two approvals. Let me know if there is a better approach to approvals and merging! |
|
It looks like the default port for the tempo query frontend has changed from 3100 to 3200 at some point, so trace metrics don't work with this chart as it stands In order to get this chart to work I've had to change the values for the data sources in values.yaml to :3200
|
|
Thanks @danbrad, well spotted! Pushed the fix. |
Signed-off-by: timberhill <[email protected]>
|
@zanhsieh / @zalegrala Sorry to ping you again, but the PR is going out of date as we speak 😆 |
2fb483d to
2892df7
Compare
Signed-off-by: timberhill <[email protected]>
|
@timberhill A ping here will usually get my attention within a couple days. I'm returning from a few days away, apologies for the delay. For more prompt review, you can ping me in the community slack. |
|
Found this PR while looking at how out of date the referenced chart is and asked in the community Slack in |
|
Hi, you should assume that this chart this deprecated . The dependencies like loki-distributed is deprecated , I guess the same belongs to mimir. Oncall itself is deprecated as well. |
Thought so too. I needed something quick for a project and this seemd like a good all in one thing. Would be nice to update this, but keep in mind a new release will break a lot of peoples setups. Two major grafana version updates (bundled is v10, current is v12) changes in ports, config docs and values schema in sub-charts. Kind of a tricky situation |
Contributes to #3885
Fixes #3885