jvm-observ-lib: Add java_micrometer_with_suffixes option #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is yet another metric pattern combinatino. When micrometer metrics are received through OTEL bridge then prometheus suffixes might not be added. Adding this option to jvm/process lib
Dasomeone
reviewed
Dec 10, 2024
| @@ -7,7 +7,8 @@ Supports the following sources: | |||
| - `prometheus` (https://prometheus.github.io/client_java/instrumentation/jvm/#jvm-memory-metrics). This also works for jmx_exporter (javaagent mode) starting from 1.0.1 release. | |||
| - `otel` (https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/jmx-metrics/docs/target-systems/jvm.md) | |||
| - `otel_with_suffixes` same as otel with add_metric_suffixes=true in otelcollector | |||
| - `java_micrometer` (springboot) (https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmMemoryMetrics.java) | |||
| - `java_micrometer` (springboot) (https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmMemoryMetrics.java). Can be seen when Micrometer to OTEL bridge is used. | |||
| - `java_micrometer_with_suffixes` (springboot) same, but with prometheus suffixes | |||
There was a problem hiding this comment.
From a readability perspective, could you rename this to java_micrometer_bridge_prom and java_micrometer_bridge_otel or similar? I think it'd be a fair bit cleaner
| @@ -45,7 +46,7 @@ local jvm = | |||
| uid: 'jvm-sample', | |||
| dashboardNamePrefix: 'JVM', | |||
| dashboardTags: ['java', 'jvm'], | |||
| metricsSource: 'java_micrometer', // or java_otel, prometheus, | |||
| metricsSource: 'java_micrometer_with_suffixes', // or java_otel, prometheus, | |||
There was a problem hiding this comment.
See above comment, where at first read it can be confusing what exactly the source is here. Additionally would be good to mention the otel bridge option
| @@ -15,7 +15,7 @@ local processlib = import 'process-observ-lib/main.libsonnet'; | |||
| filteringSelector: this.config.filteringSelector, | |||
| groupLabels: this.config.groupLabels, | |||
| instanceLabels: this.config.instanceLabels, | |||
| uid: this.config.uid, | |||
| uid: this.config.uid - '-jvm', | |||
There was a problem hiding this comment.
Wouldn't this be a breaking change for any customer bookmarks etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is yet another metric pattern combination. When micrometer metrics are received through OTEL bridge then prometheus suffixes might not be added. Adding this option to jvm/process lib