Apache Mesos Mixin Modernization #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
changed the title
…i/jsonnet-libs into chore/apache-mesos-modernization
…pache-mesos-modernization
Dasomeone
reviewed
Oct 16, 2025
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Nothing new here, structure and layout looks great, just the usage of common-lib :)
Co-authored-by: Emily <[email protected]>
…i/jsonnet-libs into chore/apache-mesos-modernization
…i/jsonnet-libs into chore/apache-mesos-modernization
Dasomeone
reviewed
Oct 24, 2025
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Thank you for using the new common lib, but I think the extra setup steps can be simplified a fair bit by just utilising the common-lib defaults
aalhour
reviewed
Oct 29, 2025
aalhour
left a comment
aalhour
left a comment
There was a problem hiding this comment.
LGTM, however I'm not too deep into grafonnet and jsonnet-libs yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Apache Mesos mixin to use commonlib and g.libsonnet
Apache Mesos overview
Apache Mesos logs overview
Improvement to sample app: grafana/integration-sample-apps#72