-
Notifications
You must be signed in to change notification settings - Fork 177
chore: Apache Cassandra Mixin Modernization #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Apache Cassandra Mixin Modernization #1513
Conversation
Dasomeone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things to fix here, but overall a good improvement for sure!
| panels.keyspacesWriteLatencyPanel { gridPos+: { w: 12 } }, | ||
| panels.keyspacesReadLatencyPanel { gridPos+: { w: 12 } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite possibly an argument to be made for pushing read latency up in terms of importance and being higher on the dashboard, what do you think?
Perhaps a stat panel for highest p. 95 latency on the top row?
Dasomeone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments, but almost there! Looks great :D
…onnet-libs into feat/cassandra-modernization
Dasomeone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you Keith!
This PR modernizes the
apache-cassandra-mixinto use commonlib and g.libsonnet to generate its dashboards and alert content.Apache Cassandra overview
Notes: moved up the total disk usage up to the top of the dashbaord




Original conversion
Now:
Apache Cassandra nodes
Apache Cassandra keyspaces
Apache Cassandra logs