feat: Add ability to target headers by name #360
Conversation
e-fisher
force-pushed
the
feat/target-headers-by-name
branch
from
2a7228f to
2083453
Compare
| const [isSidebarExpanded, setIsSidebarExpanded] = useLocalStorage( | ||
| 'isSidebarExpanded', | ||
| true | ||
| ) |
There was a problem hiding this comment.
Not related to the feature, but added this as QoL to avoid closing the sidebar every time I did cmd+r to refresh the app.
| export function createCorrelationRuleInstance( | ||
| rule: CorrelationRule, | ||
| idGenerator: Generator<number> | ||
| idGenerator: IdGenerator |
There was a problem hiding this comment.
Cleaning up some "unsafe any" warnings
| import { ChevronDownIcon, ThickCheckIcon } from '@radix-ui/themes' | ||
| import { getStylesConfig, getThemeConfig } from './StyledReactSelect.styles' | ||
|
|
||
| export function StyledReactSelect<Option>( |
There was a problem hiding this comment.
Far from ideal integration of ReactSelect into Radix, it doesn't support all the props Radix's select does and has static size, but this iteration I've focused on blending it into Radix styles.
e-fisher
requested review from
going-confetti and
cristianoventura
and removed request for
a team
| export function StyledReactSelect<Option>( | ||
| props: ComponentProps<typeof Select<Option>> | ||
| ) { | ||
| const styles = useMemo(() => getStylesConfig<Option>(), []) |
There was a problem hiding this comment.
Can this be moved to just before the component function? useMemo won't be needed then.
There was a problem hiding this comment.
The only reason is passing that generic type, was getting TS errors without it :(
| const headers = filteredRequests.flatMap( | ||
| (request) => request?.[extractFrom]?.headers ?? [] | ||
| ) |
There was a problem hiding this comment.
I noticed some headers are listed in the dropdown but not generated in the script so selecting them doesn't have any effect. We could exclude them from the dropdown as well to keep consistency.
k6-studio/src/codegen/codegen.ts
Lines 189 to 191 in 5faa040
There was a problem hiding this comment.
Good call! Updated 👌
e-fisher
dismissed stale reviews from cristianoventura and going-confetti
via
d3ed6c3
Description
Add ability to target header by name in selectors, works both in correlation and parameterization rules.
I've added and styled ReactSelect to add searchable dropdowns, and used it to show header suggestions from recorded requests.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #307