feat: add type column to WebLogView #372
Conversation
cristianoventura
requested review from
going-confetti and
e-fisher
and removed request for
a team
src/components/WebLogView/Row.tsx
Outdated
| @@ -53,6 +54,11 @@ export function Row({ data, isSelected, onSelectRequest }: RowProps) { | |||
| /> | |||
| </ResponseStatusBadge> | |||
| </Table.Cell> | |||
| <Table.Cell> | |||
| <Text size="1"> | |||
| {isNonStaticAssetResponse(data) ? 'Dynamic' : 'Static'} | |||
There was a problem hiding this comment.
I was under the impression we wanted this to work similarly to the browser dev tools:
If we only want to mark static requests, I suggest something that will take less horizontal space in WebLogView - maybe an icon or something like that
There was a problem hiding this comment.
@going-confetti I made a change to include a more descriptive "type" based on the content-type returned by the request.
|
|
||
| export function getRequestType(data: ProxyData) { | ||
| if (isNonStaticAssetResponse(data)) { | ||
| return 'fetch' |
There was a problem hiding this comment.
ChromeDevTools categorizes this a bit more. I was debating whether to call it "document", "dynamic" or "fetch". Any thoughts?
There was a problem hiding this comment.
Perhaps, we can make use of the content-type header to categorize different types of dynamic requests?
There was a problem hiding this comment.
@going-confetti and I discussed that most dynamic requests have the following content types:
- text/plain
- text/html
- application/json
This makes it tricky to differentiate them so we'll leave them as fetch for now and come back later on if needed.
Description
This PR adds a new
Typecolumn to theWebLogViewcomponent to differentiate static assets from dynamic requests.How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #325