feat: Websocket communication between k6 Studio and browser #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
commented
Dec 16, 2024
| @@ -23,7 +24,7 @@ export default defineConfig((env) => { | |||
| external, | |||
| }, | |||
| }, | |||
| plugins: [pluginHotRestart('restart')], | |||
| plugins: [pluginHotRestart('restart'), tsconfigPaths()], | |||
There was a problem hiding this comment.
Allows the main process to use @/ import paths.
| @@ -22,7 +23,7 @@ export default defineConfig((env) => { | |||
| }, | |||
| }, | |||
| }, | |||
| plugins: [pluginHotRestart('reload')], | |||
| plugins: [pluginHotRestart('reload'), tsconfigPaths()], | |||
There was a problem hiding this comment.
Allows the preload process to use @/ import paths.
src/schemas/recording/v1/browser.ts
Outdated
There was a problem hiding this comment.
I assumed we're going to want to write zod schemas for recordings, i.e. HAR files, at some point so I structured this like we've done with generator/settings schemas.
allansson
requested review from
going-confetti,
cristianoventura and
e-fisher
and removed request for
a team and
cristianoventura
…n-between-studio-and-extension
allansson
deleted the
feat/websocket-communication-between-studio-and-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up WebSocket communication between k6 Studio and the recorded browser. It currently only sends a dummy event to the server and is logged in the renderer process.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Closes https://github.com/grafana/k6-cloud/issues/3087