Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add release-please action #395

Merged
merged 2 commits into from
Jan 13, 2025
Merged

ci: Add release-please action #395

merged 2 commits into from
Jan 13, 2025

Conversation

going-confetti
Copy link
Collaborator

@going-confetti going-confetti commented Jan 6, 2025

Closes #380

For now, the actual build&publish process will still be triggered manually

Comment on lines +23 to +35
fix
feat
refactor
style
test
perf
docs
deps
build
ci
chore
internal
revert
Copy link
Collaborator Author

@going-confetti going-confetti Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it needs to be this broad, but we can always make it stricter in future

Comment on lines +26 to +27
"draft": true,
"draft-pull-request": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the release PR and the GitHub release will be created as drafts

@@ -0,0 +1,29 @@
{
"bootstrap-sha": "640550975a412d71fc35875103e1c833237b168d",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha of the 0.10.0 release commit. This will be ignored once the first release PR is merged, so we can delete this later.

@going-confetti going-confetti marked this pull request as ready for review January 13, 2025 09:19
@going-confetti going-confetti requested a review from a team as a code owner January 13, 2025 09:19
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Collaborator

@cristianoventura cristianoventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

@going-confetti going-confetti merged commit 5a98e1a into main Jan 13, 2025
4 checks passed
@going-confetti going-confetti deleted the ci/release-please branch January 13, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up release automation
3 participants